Issue 9220008: Send data in chunks when writing to socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9220008: Send data in chunks when writing to socket. (Closed)

Created:
8 years, 11 months ago by Anders Johnsen

Modified:
8 years, 11 months ago

Reviewers:
cshapiro, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Send data in chunks when writing to socket. Committed: https://code.google.com/p/dart/source/detail?r=3628

Patch Set 2 : Remove use of std. #

Patch Set 3 : Limit buffer to input length and use KB constant. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -5 lines)			Patch
	M	runtime/bin/socket.cc	View	1 2	2 chunks	+19 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

https://chromiumcodereview.appspot.com/9220008/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://chromiumcodereview.appspot.com/9220008/diff/1/runtime/bin/socket.cc#newcode5 runtime/bin/socket.cc:5: #include <algorithm> Is this okay?

8 years, 11 months ago (2012-01-26 19:50:27 UTC) #1

lgtm