Send data in chunks when writing to socket.

runtime/bin/socket.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+#include <algorithm>

[Anders Johnsen, 2012/01/26 19:50:27]

Is this okay?

+
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 
 #include "include/dart_api.h"
 
 
 void FUNCTION_NAME(Socket_CreateConnect)(Dart_NativeArguments args) {
   Dart_EnterScope();
   Dart_Handle socketobj = Dart_GetNativeArgument(args, 0);
   const char* host =
@@ skipping 66 matching lines @@
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t buffer_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
   ASSERT(!Dart_IsError(result));
   ASSERT((offset + length) <= buffer_len);
 
   if (Dart_IsVMFlagSet("short_socket_write")) {
     length = (length + 1) / 2;
   }
 
-  uint8_t* buffer = new uint8_t[length];
-  result = Dart_ListGetAsBytes(buffer_obj, offset, buffer, length);
-  ASSERT(!Dart_IsError(result));
-  intptr_t total_bytes_written =
-      Socket::Write(socket, reinterpret_cast<void*>(buffer), length);
+  // Send data in chunks of 16KB.
+  const intptr_t max_chunk_length = 16384;
+  uint8_t* buffer = new uint8_t[max_chunk_length];
+  intptr_t total_bytes_written = 0;
+  intptr_t bytes_written = 0;
+  do {
+    intptr_t chunk_length =
+        std::min(max_chunk_length, length - total_bytes_written);
+    result = Dart_ListGetAsBytes(buffer_obj,
+                                 offset + total_bytes_written,
+                                 buffer,
+                                 chunk_length);
+    ASSERT(!Dart_IsError(result));
+    bytes_written =
+        Socket::Write(socket, reinterpret_cast<void*>(buffer), chunk_length);
+    total_bytes_written += bytes_written;
+  } while (bytes_written > 0 && total_bytes_written < length);
   delete[] buffer;
   Dart_SetReturnValue(args, Dart_NewInteger(total_bytes_written));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_GetPort)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t socket =
       DartUtils::GetIntegerInstanceField(Dart_GetNativeArgument(args, 0),
@@ skipping 42 matching lines @@
                                          DartUtils::kIdFieldName);
   Dart_Handle socketobj = Dart_GetNativeArgument(args, 1);
   intptr_t newSocket = ServerSocket::Accept(socket);
   if (newSocket >= 0) {
     DartUtils::SetIntegerInstanceField(
         socketobj, DartUtils::kIdFieldName, newSocket);
   }
   Dart_SetReturnValue(args, Dart_NewBoolean(newSocket >= 0));
   Dart_ExitScope();
 }