Issue 986: Static type warning when overriding static super members

Issue 986: Static type warning when overriding static super members
http://code.google.com/p/dart/issues/detail?id=986

Truth table:
Super    | static  | instance
Local    |         |
---------+---------+---------    
static   | warning | error  
instance | warning | warning

Ancillary adition: Warnings are now colored differently from errors to help
distinguish between the two.

R=zundel
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3435

[codefu, 2012-01-12 15:57:19]

http://codereview.chromium.org/9186037/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

http://codereview.chromium.org/9186037/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:17:
CANNOT_OVERRIDE_STATIC_MEMBER("overriding static member %s of %s"),
What is the language to be used for static warnings? "cannot" seems wrong since
we still compile and the code will run.

[zundel, 2012-01-13 15:57:29]

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java (right):

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/PrettyErrorFormatter.java:31: public
static final String NO_COLOR = "\033[0m";
(aside)  John and I conferred on these changes ahead of time to make sure the
look good on both a black on white and white on black color terminal.

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:17:
CANNOT_OVERRIDE_STATIC_MEMBER("overriding static member %s of %s"),
convention is that the name of the enum match the prefix of the default english
translation, so either remove CANNOT_OVERRIDE and change it in the enum, or
change the text to match.

http://codereview.chromium.org/9186037/diff/2001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java
(right):

http://codereview.chromium.org/9186037/diff/2001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java:67:
public void close() {
I'm not sure why you removed the throws here, its a part of the Reader interface
when I looked it up in javadoc.

[codefu, 2012-01-13 18:50:47]

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java (right):

http://codereview.chromium.org/9186037/diff/2001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java:17:
CANNOT_OVERRIDE_STATIC_MEMBER("overriding static member %s of %s"),
On 2012/01/13 15:57:30, zundel wrote:
> convention is that the name of the enum match the prefix of the default
english
> translation, so either remove CANNOT_OVERRIDE and change it in the enum, or
> change the text to match.

Done.

http://codereview.chromium.org/9186037/diff/2001/compiler/javatests/com/googl...
File compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java
(right):

http://codereview.chromium.org/9186037/diff/2001/compiler/javatests/com/googl...
compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java:67:
public void close() {
On 2012/01/13 15:57:30, zundel wrote:
> I'm not sure why you removed the throws here, its a part of the Reader
interface
> when I looked it up in javadoc.

There was a warning in Eclipse about not actually throwing an exception (which
this does no work), hence my reason for removing it here and above at
getSourceReader().  If something was later added that did throw, it would
complain and ask to be matched up with the interface.

[zundel, 2012-01-17 14:32:36]

LGTM