compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 9186037: Issue 986: Static type warning when overriding static super members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 9186037: Issue 986: Static type warning when overriding static super members (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updating enum name Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index c9761333d2a33ed23b0db34c9bfc79ffed9ce477..f5c31f393c7d19b2f88e12d298fc6b373c839d6c 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1704,7 +1704,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

private boolean canOverride(DartExpression node, Modifiers modifiers, Element element) {

if (element.getModifiers().isStatic()) {

- onError(node, ResolverErrorCode.CANNOT_OVERRIDE_STATIC_MEMBER,

+ onError(node, TypeErrorCode.OVERRIDING_INHERITED_STATIC_MEMBER,

element.getName(), element.getEnclosingElement().getName());

return false;

} else if (modifiers.isStatic()) {