Issue 9129023: adds array bounds checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9129023: adds array bounds checking (Closed)

Created:
8 years, 11 months ago by jimhug

Modified:
8 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

adds array bounds checking also adds a --unchecked flag to optionally disable this bounds checking so that we can monitor the performance impact - currently the impact seems to be from zero to about 4x slower depending on the specific benchmark Committed: https://code.google.com/p/dart/source/detail?r=3555

Patch Set 1 #

Patch Set 2 : merged #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -58 lines)			Patch
M	frog/corejs.dart	View		8 chunks	+57 lines, -19 lines	0 comments	Download
M	frog/frog_options.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	frog/gen.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	frog/lib/corelib_impl.dart	View		3 chunks	+24 lines, -6 lines	0 comments	Download
M	frog/member.dart	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	frog/minfrog	View	1	17 chunks	+90 lines, -23 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages