adds array bounds checking

frog/lib/corelib_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("dart:coreimpl");
 
 #source("../../corelib/src/implementation/dual_pivot_quicksort.dart");
 #source("../../corelib/src/implementation/duration_implementation.dart");
 #source("../../corelib/src/implementation/exceptions.dart");
 #source("../../corelib/src/implementation/future_implementation.dart");
@@ skipping 51 matching lines @@
   void sort(int compare(E a, E b)) native;
   void copyFrom(List<Object> src, int srcStart, int dstStart, int count) native;
   int indexOf(E element, [int start]) native;
   int lastIndexOf(E element, [int start]) native;
   void clear() { length = 0; }
 
   E removeLast() native "return this.pop();";
 
   E last() => this[this.length-1];
 
-  List<E> getRange(int start, int length) native
-    "return this.slice(start, start + length);";
+  List<E> getRange(int start, int length) native """
+    if (length == 0) return [];
+    if (length < 0) throw new IllegalArgumentException('length');
+    if (start < 0 || start + length > this.length)
+      throw new IndexOutOfRangeException(start);
+    return this.slice(start, start + length);
+  """ { throw new IllegalArgumentException('');
+        throw new IndexOutOfRangeException(0); }
 
   void setRange(int start, int length, List<E> from, [int startFrom = 0]) {
     // length of 0 prevails and should not throw exceptions.
     if (length == 0) return;
     if (length < 0) throw new IllegalArgumentException('length is negative');
 
     if (start < 0) throw new IndexOutOfRangeException(start);
 
     int end = start + length;
     if (end > this.length) throw new IndexOutOfRangeException(end);
 
     if (startFrom < 0) throw new IndexOutOfRangeException(startFrom);
 
     int endFrom = startFrom + length;
     if (endFrom > from.length) throw new IndexOutOfRangeException(endFrom);
 
     for (var i = 0; i < length; ++i)
       this[start + i] = from[startFrom + i];
   }
 
-  void removeRange(int start, int length) native "this.splice(start, length);";
+  void removeRange(int start, int length) native """
+    if (length == 0) return;
+    if (length < 0) throw new IllegalArgumentException('length');
+    if (start < 0 || start + length > this.length)
+      throw new IndexOutOfRangeException(start);
+    this.splice(start, length);
+  """ { throw new IllegalArgumentException('');
+        throw new IndexOutOfRangeException(0); }
 
-  void insertRange(int start, int length, [E initialValue]) native
-    """
+  void insertRange(int start, int length, [E initialValue]) native """
+    if (length == 0) return;
+    if (length < 0) throw new IllegalArgumentException('length');
+    if (start < 0 || start > this.length)
+      throw new IndexOutOfRangeException(start);
+
     // Splice in the values with a minimum of array allocations.
     var args = new Array(length + 2);
     args[0] = start;
     args[1] = 0;
     for (var i = 0; i < length; i++) {
       args[i + 2] = initialValue;
     }
     this.splice.apply(this, args);
-    """;
+    """ { throw new IllegalArgumentException('');
+          throw new IndexOutOfRangeException(0); }
 
   // Collection<E> members:
   void forEach(void f(E element)) native;
   Collection<E> filter(bool f(E element)) native;
   Collection map(f(E element)) native;
   bool every(bool f(E element)) native;
   bool some(bool f(E element)) native;
   bool isEmpty() => length == 0;
 
   // Iterable<E> members:
@@ skipping 388 matching lines @@
     } else if (isNaN()) {
       if (other.isNaN()) {
         return 0;
       }
       return 1;
     } else {
       return -1;
     }
   }
 }