Issue 85303004: Remove old warning code for wrong usage of warnings in co19

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 85303004: Remove old warning code for wrong usage of warnings in co19 (Closed)

Created:
7 years ago by ricow1

Modified:
7 years ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove old warning code for wrong usage of warnings in co19 Committed: https://code.google.com/p/dart/source/detail?r=30621

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM https://chromiumcodereview.appspot.com/85303004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://chromiumcodereview.appspot.com/85303004/diff/1/tools/testing/dart/test_suite.dart#newcode1536 tools/testing/dart/test_suite.dart:1536: bool hasDynamicTypeError = contents.contains("@dynamic-type-error"); Remove the this line ...

7 years ago (2013-11-25 12:47:05 UTC) #2

ricow1

7 years ago (2013-11-25 12:53:21 UTC) #3

https://chromiumcodereview.appspot.com/85303004/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/85303004/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_suite.dart:1536: bool hasDynamicTypeError =
contents.contains("@dynamic-type-error");
On 2013/11/25 12:47:06, kustermann wrote:
> Remove the this line as well.

Done.

Expand Messages | Collapse Messages

Issue 85303004: Remove old warning code for wrong usage of warnings in co19 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages