Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 85303004: Remove old warning code for wrong usage of warnings in co19 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 30617)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -1533,24 +1533,9 @@
bool hasCompileError = contents.contains("@compile-error");
bool hasRuntimeError = contents.contains("@runtime-error");
- bool hasDynamicTypeError = contents.contains("@dynamic-type-error");
bool hasStaticWarning = contents.contains("@static-warning");
bool isMultitest = multiTestRegExp.hasMatch(contents);
- if (hasDynamicTypeError) {
- // TODO(ahe): Remove this warning when co19 no longer uses this tag.
-
- // @dynamic-type-error has been replaced by tests that use
- // tests/co19/src/Utils/dynamic_check.dart to dynamically detect
- // if a test is running in checked mode or not and change its
- // expectations accordingly.
-
- // Using stderr.writeString to avoid breaking dartc/junit_tests
- // which parses the output of the --list option.
- stderr.writeln(
- "Warning: deprecated @dynamic-type-error tag used in $filePath");
- }
-
return {
"vmOptions": <List>[[]],
"sharedOptions": <String>[],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698