Issue 845443002: Get ready to publish 0.1.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 845443002: Get ready to publish 0.1.0. (Closed)

Created:
5 years, 11 months ago by Bob Nystrom

Modified:
5 years, 11 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Get ready to publish 0.1.0. R=pquitslund@google.com Committed: 5e909f43c297883c529a28eda07820c52e2f45e8

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -28 lines)			Patch
M	README.md	View	3 chunks	+15 lines, -16 lines	0 comments	Download
D	notes.txt	View	1 chunk	+0 lines, -11 lines	2 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pquitslund

LGTM. Sweet! https://chromiumcodereview.appspot.com/845443002/diff/1/notes.txt File notes.txt (left): https://chromiumcodereview.appspot.com/845443002/diff/1/notes.txt#oldcode11 notes.txt:11: - Ifs with an else where the ...

5 years, 11 months ago (2015-01-08 04:52:17 UTC) #3

Bob Nystrom

https://chromiumcodereview.appspot.com/845443002/diff/1/notes.txt File notes.txt (left): https://chromiumcodereview.appspot.com/845443002/diff/1/notes.txt#oldcode11 notes.txt:11: - Ifs with an else where the if or ...

5 years, 11 months ago (2015-01-08 17:25:09 UTC) #4

Bob Nystrom

5 years, 11 months ago (2015-01-08 17:25:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e909f43c297883c529a28eda07820c52e2f45e8 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages