notes.txt - Issue 845443002: Get ready to publish 0.1.0.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: notes.txt

Issue 845443002: Get ready to publish 0.1.0. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 Open questions:

2

3 - If a collection fits on one line, should it always be made one line?

4 - When should a parameter/argument list be split to one item per line versus

5 packing as many items as fit on each line?

6

7 ---

8

9 Things we should lint on:

10 - Unnecessary {} in interpolation.

11 - Ifs with an else where the if or else is not a curly body.
pquitslund 2015/01/08 04:52:17 These are awesome. Do you have open issues for th These are awesome. Do you have open issues for them? Bob Nystrom 2015/01/08 17:25:09 I moved over a linter bug for the last one. I'll f Show quoted text On 2015/01/08 04:52:17, pquitslund wrote: > These are awesome. Do you have open issues for them? I moved over a linter bug for the last one. I'll file a bug for the first one now.
OLD	NEW

« no previous file with comments | « README.md ('k') | pubspec.yaml » ('j') | no next file with comments »