Issue 834353002: camelCase constants. Down with ALL_CAPS!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 834353002: camelCase constants. Down with ALL_CAPS! (Closed)

Created:
5 years, 11 months ago by Bob Nystrom

Modified:
5 years, 11 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

camelCase constants. Down with ALL_CAPS! Also, I took some old TODO comments and moved them to real github issues. BUG=https://github.com/dart-lang/dart_style/issues/116 R=pquitslund@google.com Committed: c6c88174a354919136cba4efe71e56d2978f972d

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -119 lines)			Patch
M	example/format.dart	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	lib/src/chunk.dart	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/src/debug.dart	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	lib/src/line_splitter.dart	View	10 chunks	+14 lines, -14 lines	0 comments	Download
M	lib/src/line_writer.dart	View	8 chunks	+23 lines, -23 lines	0 comments	Download
M	lib/src/nesting.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/src/source_visitor.dart	View	4 chunks	+9 lines, -9 lines	0 comments	Download
M	lib/src/whitespace.dart	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	test/formatter_test.dart	View	1 chunk	+0 lines, -52 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pquitslund

LGTM https://chromiumcodereview.appspot.com/834353002/diff/1/example/format.dart File example/format.dart (right): https://chromiumcodereview.appspot.com/834353002/diff/1/example/format.dart#newcode36 example/format.dart:36: " ", "${Color.gray}$unicodeMidDot${Color.none}"); Nice.

5 years, 11 months ago (2015-01-06 19:36:25 UTC) #3

Bob Nystrom

5 years, 11 months ago (2015-01-06 20:04:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c6c88174a354919136cba4efe71e56d2978f972d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages