Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: lib/src/debug.dart

Issue 834353002: camelCase constants. Down with ALL_CAPS! (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/debug.dart
diff --git a/lib/src/debug.dart b/lib/src/debug.dart
index 334c7ca837026d6f9c6b93362ce9e1abcfd252ba..09fff058e33b613c82ce869a088490512588ca90 100644
--- a/lib/src/debug.dart
+++ b/lib/src/debug.dart
@@ -14,10 +14,8 @@ bool debugFormatter = false;
bool useAnsiColors = false;
-const UNICODE_SECT = "\u00a7";
-const UNICODE_MIDDOT = "\u00b7";
-const UNICODE_LASQUO = "\u2039";
-const UNICODE_RASQUO = "\u203a";
+const unicodeSection = "\u00a7";
+const unicodeMidDot = "\u00b7";
/// Constants for ANSI color escape codes.
class Color {
@@ -61,7 +59,7 @@ void dumpLine(List<Chunk> chunks,
if (chunk.isSoftSplit) {
var color = splits.contains(chunk.param) ? Color.green : Color.gray;
- buffer.write("$color$UNICODE_SECT${chunk.param.cost}");
+ buffer.write("$color$unicodeSection${chunk.param.cost}");
if (chunk.nesting != -1) buffer.write(":${chunk.nesting}");
buffer.write("${Color.none}");
} else if (chunk.isHardSplit) {
@@ -102,7 +100,7 @@ void dumpLines(List<Chunk> chunks,
}
// Should have a valid set of splits when we get here.
- assert(indent != INVALID_SPLITS);
+ assert(indent != invalidSplits);
} else {
if (chunk.spaceWhenUnsplit) buffer.write(" ");
}
« example/format.dart ('K') | « lib/src/chunk.dart ('k') | lib/src/line_splitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698