Issue 63173006: Add test for protocol buffer hash code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63173006: Add test for protocol buffer hash code (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master

Visibility:
Public.

More Reviews

Description

Add test for protocol buffer hash code This tests the hach code implemented in https://chromiumcodereview.appspot.com/64753003. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protoc-plugin/commit/4710be9

Patch Set 2 : Addressed review comments #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -1 line)			Patch
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/all_tests.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	test/hash_code_test.dart	View	1	1 chunk	+175 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://chromiumcodereview.appspot.com/63173006/diff/1/test/hash_code_test.dart File test/hash_code_test.dart (right): https://chromiumcodereview.appspot.com/63173006/diff/1/test/hash_code_test.dart#newcode25 test/hash_code_test.dart:25: var m2 = new TestAllTypes()..optionalInt32 = 42;; nit: ...

7 years, 1 month ago (2013-11-07 21:07:24 UTC) #2

Søren Gjesse

https://chromiumcodereview.appspot.com/63173006/diff/1/test/hash_code_test.dart File test/hash_code_test.dart (right): https://chromiumcodereview.appspot.com/63173006/diff/1/test/hash_code_test.dart#newcode25 test/hash_code_test.dart:25: var m2 = new TestAllTypes()..optionalInt32 = 42;; On 2013/11/07 ...

7 years, 1 month ago (2013-11-08 08:08:31 UTC) #3

Søren Gjesse

7 years, 1 month ago (2013-11-08 08:08:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r4710be9 (presubmit successful).

Expand Messages | Collapse Messages

Issue 63173006: Add test for protocol buffer hash code (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages