Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 64753003: Update hashCode to hash the entire message (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart-protobuf.git@master
Visibility:
Public.

Description

Update hashCode to hash the entire message This is inspired by the way the hash code is generated for protocol buffers in Java, see: https://code.google.com/p/protobuf/source/browse/trunk/java/src/main/java/com/google/protobuf/AbstractMessage.java#188 For lists the Jenkins hash function is used. Tests are in https://chromiumcodereview.appspot.com/63173006. R=sigmund@google.com BUG= Committed: https://github.com/dart-lang/protobuf/commit/c5fdfcb

Patch Set 1 #

Patch Set 2 : Update version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -12 lines) Patch
M lib/generated_message.dart View 4 chunks +58 lines, -8 lines 0 comments Download
M lib/pb_list.dart View 1 chunk +12 lines, -1 line 0 comments Download
M lib/unknown_field_set.dart View 2 chunks +30 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-07 16:51:59 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 1 month ago (2013-11-07 21:06:34 UTC) #2
Søren Gjesse
7 years, 1 month ago (2013-11-08 07:58:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as rc5fdfcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698