Add windows installer functionallity to editor build script.

Add windows installer functionallity to editor build script.

Refactor create_mac_installer to pull out generic functionality.
Change naming util class to not include zip in name of editor file
Change windows installer creation script to support a directory as input in addition to a zip file
Committed: https://code.google.com/p/dart/source/detail?r=29440

[kustermann, 2013-10-29 08:44:47]

lgtm in general.

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build.py
File editor/build/build.py (right):

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:454: 'wix')
Do we already have this in our DEPS file?

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:469: dart_folder_icon, "Dart Distribution"])
You could rename this to "Dart Installer" -- so we're consistent with windows
(but I don't really care).

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:489: unzip_dir = os.path.join(temp_dir, 'dart')
Isn't this creating a directory structure like this?:

temp_dir/dart/dart/DartEditor.exe

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:492: dartium_zip.UnZip(unzip_dir)
This is not dartium. Rename it.

+ Do we need to call "dartium_zip.close()" to free the zip file [might cause
issues on windows]?

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
File tools/create_windows_installer.py (right):

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
tools/create_windows_installer.py:76: ExtractZipFile(options.zip_file_location,
temp_dir)
Where is "temp_dir" defined?

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
tools/create_windows_installer.py:345: input_location =
GetInputDirectory(options)
Remove this and add the following line inside "with utils.TempDir('installer')
as temp_dir":

  input_location = GetInputDirectory(temp_dir, GetOptions())

[ricow1, 2013-10-29 08:59:05]

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build.py
File editor/build/build.py (right):

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:454: 'wix')
On 2013/10/29 08:44:47, kustermann wrote:
> Do we already have this in our DEPS file?

No, and we will not, I will explicitly check this out on the bot, see:
https://codereview.chromium.org/50423002

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:469: dart_folder_icon, "Dart Distribution"])
On 2013/10/29 08:44:47, kustermann wrote:
> You could rename this to "Dart Installer" -- so we're consistent with windows
> (but I don't really care).

Done.

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:489: unzip_dir = os.path.join(temp_dir, 'dart')
On 2013/10/29 08:44:47, kustermann wrote:
> Isn't this creating a directory structure like this?:
> 
> temp_dir/dart/dart/DartEditor.exe 

Indeed it is, changed

https://chromiumcodereview.appspot.com/47553006/diff/30001/editor/build/build...
editor/build/build.py:492: dartium_zip.UnZip(unzip_dir)
On 2013/10/29 08:44:47, kustermann wrote:
> This is not dartium. Rename it.
> 
> + Do we need to call "dartium_zip.close()" to free the zip file [might cause
> issues on windows]?

renamed - regarding close I think you are confusing ziputils with zipfile ->
ziputils is another python lib in this directory that will handle this

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
File tools/create_windows_installer.py (right):

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
tools/create_windows_installer.py:76: ExtractZipFile(options.zip_file_location,
temp_dir)
On 2013/10/29 08:44:47, kustermann wrote:
> Where is "temp_dir" defined?

Fixed

https://chromiumcodereview.appspot.com/47553006/diff/30001/tools/create_windo...
tools/create_windows_installer.py:345: input_location =
GetInputDirectory(options)
On 2013/10/29 08:44:47, kustermann wrote:
> Remove this and add the following line inside "with utils.TempDir('installer')
> as temp_dir":
> 
>   input_location = GetInputDirectory(temp_dir, GetOptions())

Done.