Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/bots/bot_utils.py

Issue 47553006: Add windows installer functionallity to editor build script. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/build/build.py ('k') | tools/create_windows_installer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/bot_utils.py
===================================================================
--- tools/bots/bot_utils.py (revision 29230)
+++ tools/bots/bot_utils.py (working copy)
@@ -99,9 +99,9 @@
return '/'.join([self.editor_directory(revision),
self.editor_zipfilename(system, arch)])
- def editor_installer_zipfilepath(self, revision, system, arch, extension):
+ def editor_installer_filepath(self, revision, system, arch, extension):
return '/'.join([self.editor_directory(revision),
- self.editor_installer_zipfilename(system, arch, extension)])
+ self.editor_installer_filename(system, arch, extension)])
def sdk_zipfilepath(self, revision, system, arch, mode):
return '/'.join([self.sdk_directory(revision),
@@ -148,8 +148,8 @@
return 'darteditor-%s-%s.zip' % (
SYSTEM_RENAMES[system], ARCH_RENAMES[arch])
- def editor_installer_zipfilename(self, system, arch, extension):
- assert extension in ['dmg']
+ def editor_installer_filename(self, system, arch, extension):
+ assert extension in ['dmg', 'msi']
return 'darteditor-installer-%s-%s.%s' % (
SYSTEM_RENAMES[system], ARCH_RENAMES[arch], extension)
« no previous file with comments | « editor/build/build.py ('k') | tools/create_windows_installer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698