Parameterize uri resolution and parsing of options, use package:path

Parameterize uri resolution and parsing of options, use package:path.

This helps make the compiler more configurable
to embed it in other systems (like pub transformers)

R=cbracken@google.com

Committed: https://github.com/dart-lang/protoc-plugin/commit/e94fb50

[Siggi Cherem (dart-lang), 2014-05-07 23:30:44]

https://chromiumcodereview.appspot.com/269823003/diff/60001/.gitignore
File .gitignore (right):

https://chromiumcodereview.appspot.com/269823003/diff/60001/.gitignore#newcode7
.gitignore:7: *.swp
:-)

https://chromiumcodereview.appspot.com/269823003/diff/60001/lib/code_generato...
File lib/code_generator.dart (left):

https://chromiumcodereview.appspot.com/269823003/diff/60001/lib/code_generato...
lib/code_generator.dart:64: factory GenerationOptions(request, response) {
I refactored this a bit in options.dart, the main change is that I split the
parsing of the option list, from the parsing of an individual option. That makes
it more configurable.

[Chris Bracken, 2014-05-16 19:58:44]

lgtm

Do you think it's worth the extra abstraction to be able to swap in any
GenerationOptionsParser, or would it be sufficient to always use the behaviour
in genericGenerationOptionsParser() and make the Map<String,SingleOptionsParser>
the only point of configuration?

https://codereview.chromium.org/269823003/diff/60001/.gitignore
File .gitignore (right):

https://codereview.chromium.org/269823003/diff/60001/.gitignore#newcode7
.gitignore:7: *.swp
On 2014/05/07 23:30:44, Siggi Cherem (dart-lang) wrote:
> :-)

even better:
*.sw?

https://codereview.chromium.org/269823003/diff/60001/lib/options.dart
File lib/options.dart (right):

https://codereview.chromium.org/269823003/diff/60001/lib/options.dart#newcode61
lib/options.dart:61: final Map<String, String> fieldNameOverrides;
+1 for the new name

[Siggi Cherem (dart-lang), 2014-05-16 21:33:40]

On 2014/05/16 19:58:44, Chris Bracken wrote:
> lgtm
> 
> Do you think it's worth the extra abstraction to be able to swap in any
> GenerationOptionsParser, or would it be sufficient to always use the behaviour
> in genericGenerationOptionsParser() and make the
Map<String,SingleOptionsParser>
> the only point of configuration?

Good point. Done.

> 
> https://codereview.chromium.org/269823003/diff/60001/.gitignore
> File .gitignore (right):
> 
> https://codereview.chromium.org/269823003/diff/60001/.gitignore#newcode7
> .gitignore:7: *.swp
> On 2014/05/07 23:30:44, Siggi Cherem (dart-lang) wrote:
> > :-)
> 
> even better:
> *.sw?
> 
> https://codereview.chromium.org/269823003/diff/60001/lib/options.dart
> File lib/options.dart (right):
> 
>
https://codereview.chromium.org/269823003/diff/60001/lib/options.dart#newcode61
> lib/options.dart:61: final Map<String, String> fieldNameOverrides;
> +1 for the new name

[Siggi Cherem (dart-lang), 2014-05-16 21:33:46]

https://chromiumcodereview.appspot.com/269823003/diff/60001/.gitignore
File .gitignore (right):

https://chromiumcodereview.appspot.com/269823003/diff/60001/.gitignore#newcode7
.gitignore:7: *.swp
On 2014/05/16 19:58:45, Chris Bracken wrote:
> On 2014/05/07 23:30:44, Siggi Cherem (dart-lang) wrote:
> > :-)
> 
> even better:
> *.sw?

nice :)

[Siggi Cherem (dart-lang), 2014-05-16 21:33:58]

PTAL :)

[Chris Bracken, 2014-05-16 22:03:19]

lgtm

https://codereview.chromium.org/269823003/diff/100001/lib/protobuf_field.dart
File lib/protobuf_field.dart (right):

https://codereview.chromium.org/269823003/diff/100001/lib/protobuf_field.dart...
lib/protobuf_field.dart:111: ProtobufContainer parent,
good catch!

[Siggi Cherem (dart-lang), 2014-05-16 22:09:17]

Committed patchset #2 manually as re94fb50 (presubmit successful).