Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: lib/protobuf_field.dart

Issue 269823003: Parameterize uri resolution and parsing of options, use package:path (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/output_config.dart ('k') | lib/protoc.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/protobuf_field.dart
diff --git a/lib/protobuf_field.dart b/lib/protobuf_field.dart
index 897de78780aaaa0c50208d7c1f93253e6dd5bad7..ca6d4d24fb777f0711ea28f2be6d3ee7dad30725 100644
--- a/lib/protobuf_field.dart
+++ b/lib/protobuf_field.dart
@@ -108,7 +108,7 @@ class ProtobufField {
factory ProtobufField(FieldDescriptorProto field,
- MessageGenerator parent,
+ ProtobufContainer parent,
Chris Bracken 2014/05/16 22:03:19 good catch!
GenerationContext context) {
bool required = field.label == FieldDescriptorProto_Label.LABEL_REQUIRED;
bool repeats = field.label == FieldDescriptorProto_Label.LABEL_REPEATED;
@@ -372,8 +372,8 @@ class ProtobufField {
}
return underscoresToCamelCase(name);
}
- var name = context.options.fieldNameOption(fqname);
- return (name != null) ? name : underscoresToCamelCase(_field.name);
+ var name = context.options.fieldNameOverrides[fqname];
+ return name != null ? name : underscoresToCamelCase(_field.name);
}
int get wireType {
« no previous file with comments | « lib/output_config.dart ('k') | lib/protoc.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698