Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2107023003: stop using dart2dart in Makefile (Closed)

Created:
4 years, 5 months ago by skybrian
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-protoc-plugin.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop using dart2dart in Makefile It has been deprecated for a long time and no longer works in Dart 1.18. BUG=https://github.com/dart-lang/dart-protoc-plugin/issues/58 Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/c6b927d8b882d5a913f8fa36e62ecf6ec1435913

Patch Set 1 #

Patch Set 2 : fix description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M Makefile View 2 chunks +2 lines, -10 lines 0 comments Download
A bin/protoc-gen-dart View 1 chunk +2 lines, -0 lines 0 comments Download
D prepend.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
skybrian
This is enough to get "make run-tests" to work. I'm not sure how open source ...
4 years, 5 months ago (2016-06-29 01:02:31 UTC) #3
skybrian
(Changed reviewer because Søren is on vacation.)
4 years, 5 months ago (2016-07-19 18:24:44 UTC) #5
Søren Gjesse
On 2016/07/19 18:24:44, skybrian wrote: > (Changed reviewer because Søren is on vacation.) lgtm Regarding ...
4 years, 4 months ago (2016-08-02 11:31:14 UTC) #6
skybrian
4 years, 4 months ago (2016-08-19 00:11:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c6b927d8b882d5a913f8fa36e62ecf6ec1435913 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698