Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: Makefile

Issue 2107023003: stop using dart2dart in Makefile (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: fix description Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | bin/protoc-gen-dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile
diff --git a/Makefile b/Makefile
index 3f9c344193121f9b002a3297d470ce84f28caa1d..bd370d4b53a7d1aeb6afbd350bb8a1bf51298815 100644
--- a/Makefile
+++ b/Makefile
@@ -7,7 +7,7 @@ PLUGIN_SRC = \
OUTPUT_DIR=out
PLUGIN_NAME=protoc-gen-dart
-PLUGIN_PATH=$(OUTPUT_DIR)/$(PLUGIN_NAME)
+PLUGIN_PATH=bin/$(PLUGIN_NAME)
BENCHMARK_PROTOS = $(wildcard benchmark/protos/*.proto)
@@ -47,16 +47,8 @@ TEST_PROTO_SRCS=$(foreach proto, $(TEST_PROTO_LIST), \
PREGENERATED_SRCS=lib/descriptor.proto lib/plugin.proto
-
-$(PLUGIN_PATH): $(PLUGIN_SRC)
- [ -d $(OUTPUT_DIR) ] || mkdir $(OUTPUT_DIR)
- # --categories=all is a hack, it should be --categories=Server once dart2dart bug is fixed.
- dart2js --checked --output-type=dart --show-package-warnings --categories=all -o$(PLUGIN_PATH) bin/protoc_plugin.dart
- dart prepend.dart $(PLUGIN_PATH)
- chmod +x $(PLUGIN_PATH)
-
$(TEST_PROTO_LIBS): $(PLUGIN_PATH) $(TEST_PROTO_SRCS)
- [ -d $(TEST_PROTO_DIR) ] || mkdir $(TEST_PROTO_DIR)
+ [ -d $(TEST_PROTO_DIR) ] || mkdir -p $(TEST_PROTO_DIR)
protoc\
--dart_out=$(TEST_PROTO_DIR)\
-I$(TEST_PROTO_SRC_DIR)\
« no previous file with comments | « no previous file | bin/protoc-gen-dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698