Change how to set the Dart name of a field

Change how to set the Dart name of a field

The old way was by passing a --field_name flag to the protoc
generator. (However, it's doubtful whether anyone was using it.)

The new way is to use the field_name option on the .proto file.
For example:

  optional string some_field = 1 [
    (dart_options.dart_name) = "renamedField"
  ];

Based on a patch by Frederik Mutzel.

BUG=
R=frederikmutzel@google.com, sgjesse@google.com

Committed: https://github.com/dart-lang/dart-protoc-plugin/commit/d72f7601eba02240620da0109ef9b8e2523254eb

[skybrian, 2016-06-08 02:24:23]

skybrian@google.com changed reviewers:
+ frederikmutzel@google.com, sgjesse@google.com

[frederikmutzel, 2016-06-08 11:33:58]

lgtm

Thank you!

[skybrian, 2016-06-08 23:40:31]

I realized that there's not much error-checking around the dart_name option, so
I wrote some tests and refactored the code. Could you look again?

Also updated pubspec based on https://chromiumcodereview.appspot.com/2030283004/

[frederikmutzel, 2016-06-09 07:50:28]

Thanks for adding the tests :)

https://codereview.chromium.org/2043913005/diff/20001/lib/names.dart
File lib/names.dart (right):

https://codereview.chromium.org/2043913005/diff/20001/lib/names.dart#newcode143
lib/names.dart:143: throw throw new DartNameOptionException(
double throw

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart
File test/names_test.dart (right):

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart#ne...
test/names_test.dart:50: ..field.addAll([stringField("first", 1, "hello
world"),]);
just add? (also below)

[Søren Gjesse, 2016-06-09 09:07:13]

lgtm

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart
File test/names_test.dart (right):

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart#ne...
test/names_test.dart:44: expect(msg.getField(2), "one");
Also test the original first field (called first_1 now?)

[skybrian, 2016-06-09 19:09:08]

Description was changed from

==========
Change how to set the Dart name of a field

The old way was by passing a --field_name flag to the protoc
generator. (However, it's doubtful whether anyone was using it.)

The new way is to use the field_name option on the .proto file.
For example:

  optional string some_field = 1 [
    (dart_options.dart_name) = "renamedField"
  ];

Based on a patch by Frederik Mutzel.

BUG=
==========

to

==========
Change how to set the Dart name of a field

The old way was by passing a --field_name flag to the protoc
generator. (However, it's doubtful whether anyone was using it.)

The new way is to use the field_name option on the .proto file.
For example:

  optional string some_field = 1 [
    (dart_options.dart_name) = "renamedField"
  ];

Based on a patch by Frederik Mutzel.

BUG=
R=frederikmutzel@google.com, sgjesse@google.com

Committed:
https://github.com/dart-lang/dart-protoc-plugin/commit/d72f7601eba02240620da0...
==========

[skybrian, 2016-06-09 19:09:10]

Committed patchset #2 (id:20001) manually as
d72f7601eba02240620da0109ef9b8e2523254eb (presubmit successful).

[skybrian, 2016-06-09 19:10:47]

https://codereview.chromium.org/2043913005/diff/20001/lib/names.dart
File lib/names.dart (right):

https://codereview.chromium.org/2043913005/diff/20001/lib/names.dart#newcode143
lib/names.dart:143: throw throw new DartNameOptionException(
On 2016/06/09 07:50:28, frederikmutzel wrote:
> double throw

Done.

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart
File test/names_test.dart (right):

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart#ne...
test/names_test.dart:44: expect(msg.getField(2), "one");
On 2016/06/09 09:07:13, Søren Gjesse wrote:
> Also test the original first field (called first_1 now?)

Done.

https://codereview.chromium.org/2043913005/diff/20001/test/names_test.dart#ne...
test/names_test.dart:50: ..field.addAll([stringField("first", 1, "hello
world"),]);
On 2016/06/09 07:50:28, frederikmutzel wrote:
> just add? (also below)

Done.