Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: test/file_generator_test.dart

Issue 2043913005: Change how to set the Dart name of a field (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: better error checking, clean up pubspec Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/file_generator_test.dart
diff --git a/test/file_generator_test.dart b/test/file_generator_test.dart
index 380647d628c84053afacfc08bc128682d56cc000..01ac8eed80067a53ed46702576e62a315700e4df 100644
--- a/test/file_generator_test.dart
+++ b/test/file_generator_test.dart
@@ -408,70 +408,6 @@ abstract class TestServiceBase extends GeneratedService {
expect(fg.generateServerFile(), expectedServer);
});
- test('FileGenerator handles field_name options', () {
- // NOTE: Below > 80 cols because it is matching generated code > 80 cols.
- String expected = r'''
-///
-// Generated code. Do not modify.
-///
-library test;
-
-import 'package:protobuf/protobuf.dart';
-
-class PhoneNumber extends GeneratedMessage {
- static final BuilderInfo _i = new BuilderInfo('PhoneNumber')
- ..a/*<String>*/(1, 'no', PbFieldType.QS)
- ..a/*<int>*/(2, 'the_type', PbFieldType.O3)
- ..a/*<String>*/(3, 'name_', PbFieldType.OS, '\$')
- ;
-
- PhoneNumber() : super();
- PhoneNumber.fromBuffer(List<int> i, [ExtensionRegistry r = ExtensionRegistry.EMPTY]) : super.fromBuffer(i, r);
- PhoneNumber.fromJson(String i, [ExtensionRegistry r = ExtensionRegistry.EMPTY]) : super.fromJson(i, r);
- PhoneNumber clone() => new PhoneNumber()..mergeFromMessage(this);
- BuilderInfo get info_ => _i;
- static PhoneNumber create() => new PhoneNumber();
- static PbList<PhoneNumber> createRepeated() => new PbList<PhoneNumber>();
- static PhoneNumber getDefault() {
- if (_defaultInstance == null) _defaultInstance = new _ReadonlyPhoneNumber();
- return _defaultInstance;
- }
- static PhoneNumber _defaultInstance;
- static void $checkItem(PhoneNumber v) {
- if (v is !PhoneNumber) checkItemFailed(v, 'PhoneNumber');
- }
-
- String get no => $_get(0, 1, '');
- void set no(String v) { $_setString(0, 1, v); }
- bool hasNo() => $_has(0, 1);
- void clearNo() => clearField(1);
-
- int get the_type => $_get(1, 2, 0);
- void set the_type(int v) { $_setUnsignedInt32(1, 2, v); }
- bool hasThe_type() => $_has(1, 2);
- void clearThe_type() => clearField(2);
-
- String get name_ => $_get(2, 3, '\$');
- void set name_(String v) { $_setString(2, 3, v); }
- bool hasName_() => $_has(2, 3);
- void clearName_() => clearField(3);
-}
-
-class _ReadonlyPhoneNumber extends PhoneNumber with ReadonlyMessageMixin {}
-
-''';
- FileDescriptorProto fd = buildFileDescriptor();
- var request = new CodeGeneratorRequest();
- request.parameter = 'field_name=PhoneNumber.number|No,'
- 'field_name=PhoneNumber.name|Name_,'
- 'field_name=PhoneNumber.type|The_type';
- var options = parseGenerationOptions(request, new CodeGeneratorResponse());
-
- FileGenerator fg = new FileGenerator(fd);
- link(options, [fg]);
- expect(fg.generateMainFile(), expected);
- });
-
test('FileGenerator generates imports for .pb.dart files', () {
// NOTE: Below > 80 cols because it is matching generated code > 80 cols.
String expected = r'''

Powered by Google App Engine
This is Rietveld 408576698