Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 13426002: Pass an isolate to GetCurrent() (Closed)

Created:
7 years, 8 months ago by haraken
Modified:
7 years, 8 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Pass an isolate to GetCurrent() TEST=test-api.cc:GetCallingContextCallback Committed: 14146

Patch Set 1 #

Patch Set 2 : Added a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
This patch is needed for making performance regression of this WebKit patch (https://bugs.webkit.org/show_bug.cgi?id=107207) acceptable. Would ...
7 years, 8 months ago (2013-04-03 11:10:50 UTC) #1
danno
lgtm
7 years, 8 months ago (2013-04-04 13:07:56 UTC) #2
haraken
danno: Thanks! michael: Would you land it for me? (I'd like to learn V8's commit ...
7 years, 8 months ago (2013-04-04 13:12:39 UTC) #3
danno
I encourage you to familiar yourself with our documentation and land it yourself, all of ...
7 years, 8 months ago (2013-04-04 13:24:48 UTC) #4
haraken
- Can I just click the "Commit" button? - Or should I check all build ...
7 years, 8 months ago (2013-04-04 13:37:21 UTC) #5
danno
We don't have a CQ. You will need to use git-cl as described in the ...
7 years, 8 months ago (2013-04-04 14:11:42 UTC) #6
haraken
Committed patchset #2 manually as r14146 (presubmit successful).
7 years, 8 months ago (2013-04-05 02:18:06 UTC) #7
haraken
7 years, 8 months ago (2013-04-05 02:18:50 UTC) #8
Message was sent while issue was closed.
On 2013/04/05 02:18:06, haraken1 wrote:
> Committed patchset #2 manually as r14146 (presubmit successful).

Thanks. It looks like landed.

Powered by Google App Engine
This is Rietveld 408576698