test/cctest/test-api.cc - Issue 13426002: Pass an isolate to GetCurrent()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 13426002: Pass an isolate to GetCurrent() (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Added a test Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index a9780f0332644af77e4ee147747e1931d3ba9362..aa25b6265bf937f53af34f3e2b26903f3d16778d 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -13410,6 +13410,7 @@ v8::Persistent<Context> calling_context2;

static v8::Handle<Value> GetCallingContextCallback(const v8::Arguments& args) {

ApiTestFuzzer::Fuzz();

CHECK(Context::GetCurrent() == calling_context0);

+ CHECK(Context::GetCurrent(args.GetIsolate()) == calling_context0);

CHECK(Context::GetCalling() == calling_context1);

CHECK(Context::GetEntered() == calling_context2);

return v8::Integer::New(42);

« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »