Issue 131943002: Handle protocol buffer messages with no package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131943002: Handle protocol buffer messages with no package (Closed)

Created:
6 years, 11 months ago by Søren Gjesse

Modified:
6 years, 11 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dart-protoc-plugin.git@master

Visibility:
Public.

Handle protocol buffer messages with no package This fixes wrong import syntax like this in the generated files. import 'message.pb.dart' as ; R=sigmund@google.com Committed: https://github.com/dart-lang/protoc-plugin/commit/e84e3e8

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -18 lines)			Patch
M	Makefile	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/file_generator.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/protobuf_field.dart	View	1	3 chunks	+15 lines, -3 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/generated_message_test.dart	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
A +	test/protos/toplevel.proto	View		1 chunk	+1 line, -6 lines	0 comments	Download
A +	test/protos/toplevel_import.proto	View		1 chunk	+4 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Gjesse

6 years, 11 months ago (2014-01-10 07:55:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as re84e3e8 (presubmit successful).