lib/file_generator.dart - Issue 131943002: Handle protocol buffer messages with no package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/file_generator.dart

Issue 131943002: Handle protocol buffer messages with no package (Closed) Base URL: https://github.com/dart-lang/dart-protoc-plugin.git@master

Patch Set: Fix bug and updte version Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/file_generator.dart

diff --git a/lib/file_generator.dart b/lib/file_generator.dart

index 9dc674e963de13321eb08887cf2a542e10fe4540..982a8131dfee9acd3c87c0f1f779f461327537c7 100644

--- a/lib/file_generator.dart

+++ b/lib/file_generator.dart

@@ -133,7 +133,7 @@ class FileGenerator extends ProtobufContainer {

// package name.

FileGenerator fileGenerator = _context.lookupFile(import);

out.print("import '${_generatedFilePath(relativeProtoPath)}'");

- if (package != fileGenerator.package) {

+ if (package != fileGenerator.package && !fileGenerator.package.isEmpty) {

out.print(' as ${fileGenerator.packageImportPrefix}');

}

out.println(';');

« no previous file with comments | « Makefile ('k') | lib/protobuf_field.dart » ('j') | no next file with comments »