Issue 1257903002: Optimize splitting long, complex lines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1257903002: Optimize splitting long, complex lines. (Closed)

Created:
5 years, 5 months ago by Bob Nystrom

Modified:
5 years, 4 months ago

Reviewers:
pquitslund, kevmoo

CC:
reviews_dartlang.org, Jennifer Messerly

Base URL:
https://github.com/dart-lang/dart_style.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Optimize splitting long, complex lines. Fixes #391 and generally improves performance. R=pquitslund@google.com Committed: fe95076a5dba71b9fd2cbf87a8431c29401735a6

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+752 lines, -928 lines)			Patch
M	benchmark/after.dart.txt	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	lib/src/debug.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	lib/src/line_splitter.dart	View	1 chunk	+0 lines, -526 lines	0 comments	Download
A	lib/src/line_splitting/line_splitter.dart	View	1 chunk	+199 lines, -0 lines	0 comments	Download
A +	lib/src/line_splitting/rule_set.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	lib/src/line_splitting/solve_state.dart	View	15 chunks	+182 lines, -238 lines	0 comments	Download
A	lib/src/line_splitting/solve_state_queue.dart	View	1 chunk	+248 lines, -0 lines	0 comments	Download
M	lib/src/line_writer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
D	lib/src/rule_set.dart	View	1 chunk	+0 lines, -157 lines	0 comments	Download
A	test/regression/0300/0391.stmt	View	1 chunk	+115 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bob Nystrom

This cuts the time to reformat the entire repo directory from ~2 minutes to ~54s ...

5 years, 5 months ago (2015-07-26 15:48:30 UTC) #2

Bob Nystrom

5 years, 4 months ago (2015-07-27 16:48:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fe95076a5dba71b9fd2cbf87a8431c29401735a6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages