Fixed dart2js.bat so it looks for dart2js snapshot in right place.

Fixed dart2js.bat so it looks for dart2js snapshot in right place.

BUG=dartbug.com/7663
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=16669

[aam-me, 2013-01-04 05:11:25]

Hi,

  following up on discovery that dart2js.bat is looking for dart2js snapshot in
wrong place I fixed that in dart2js.bat and made sure that both dart2js.bat and
dart2js-developer.bat so are in sync with linux/mac version of dart2js shell
scripts.
  Please, take a look when you have a chance.

Thank you,
Alexander Aprelev.

[ahe, 2013-01-04 09:35:17]

LGTM, if I understood everything ;-)

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:7: setlocal enableextensions enabledelayedexpansion
I don't understand why you need "enabledelayedexpansion".  As far as I can tell,
you never change the value of EXTRA_VM_OPTIONS in a way where the % syntax
doesn't do the same.

enableextensions is needed because you call a label, I think.

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:48: for /f "tokens=2 delims=[]" %%i in ('dir /a:l ^"%~dp1^"
2^>nul ^
I don't understand this command. What is the output of dir /a:l?

I assume it is something like this:


...
\>     FILENAME [LINKS_TO]
...

Ignore the \ above, I added it to make sure the review tool didn't think it is a
quote.

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:49: ^| find ">     %~n1 ["') do (
In Unix this would be:

 grep ">     ${NAME_OF_PARAMETER_1} ["

Right?

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
File sdk/bin/dart2js_developer.bat (right):

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
sdk/bin/dart2js_developer.bat:7: set EXTRA_VM_OPTIONS=--checked
I think I'd prefer having a variable named "DART2JS_DEVELOPER_MODE".

[Johnni Winther, 2013-01-04 10:01:19]

Amazing batch file voodoo! I have (almost) no idea what it does, but it works :)

[ahe, 2013-01-04 10:13:37]

On 2013/01/04 10:01:19, Johnni Winther wrote:
> Amazing batch file voodoo! I have (almost) no idea what it does, but it works
:)

Agreed: amazing, it took me all morning to figure out what all these different
things mean.

[aam-me, 2013-01-04 13:44:59]

Yes, it was fun putting the script together. Who said it is only bash scripts
that can be unreadable :-)

Thank you for the comments and review!

Please, take another look.

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat
File sdk/bin/dart2js.bat (right):

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:7: setlocal enableextensions enabledelayedexpansion
You are right! I don't need delayed expansion.

enableextensions enables several things that are used in the script: %%~dpi,
%%~fi syntax, as well !EXTRA_VM_OPTIONS! syntax(but not the delayed expansion
semantic which is separately enabled by enabledelatedexpansion).
But these extensions actually seems to be enabled by default, so I got rid of
that.

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:48: for /f "tokens=2 delims=[]" %%i in ('dir /a:l ^"%~dp1^"
2^>nul ^
Yes, correct.

This is what dir /a:l output looks like:
===
C:\def ghi>dir /a:l \
 Volume in drive C has no label.
 Volume Serial Number is 9401-7D51

 Directory of C:\

01/03/2013  10:11 PM    <JUNCTION>     abc def
[c:\dart_bleeding\dart-repo.9\dart\build\ReleaseIA32\dart-sdk]
01/03/2013  10:56 PM    <JUNCTION>     def ghi
[c:\dart_bleeding\dart-repo.9\dart\build\ReleaseIA32\dart-sdk\bin]
===

So, what happens is that is that I'm looking for filename surrounded by right
angle bracket and left square bracket.

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js.bat#ne...
sdk/bin/dart2js.bat:49: ^| find ">     %~n1 ["') do (
Right!

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
File sdk/bin/dart2js_developer.bat (right):

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
sdk/bin/dart2js_developer.bat:7: set EXTRA_VM_OPTIONS=--checked
Thank you for the suggestion! I like it better too.

[ahe, 2013-01-04 17:14:14]

lgtm

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
File sdk/bin/dart2js_developer.bat (right):

https://chromiumcodereview.appspot.com/11740040/diff/1/sdk/bin/dart2js_develo...
sdk/bin/dart2js_developer.bat:7: set EXTRA_VM_OPTIONS=--checked
On 2013/01/04 13:44:59, aam wrote:
> Thank you for the suggestion! I like it better too.

You could also make this a "boolean" variable, for example, setting its value to
"yes" or "1".

[aam-me, 2013-01-05 02:46:19]

Thank you, Peter. I switched to using "1".