Don't extract the name of a package from its description.

Don't extract the name of a package from its description.

Instead, the pubspec is considered to be the canonical name. This has the side
effect of requiring that all dependencies have a pubspec with a name field.

BUG=5205
Committed: https://code.google.com/p/dart/source/detail?r=12517

[Bob Nystrom, 2012-09-18 01:34:47]

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart#new...
utils/pub/pub.dart:161: bool get usesEntrypoint => true;
How about "requiresEntrypoint"?

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart#new...
utils/pub/pub.dart:208: .transform((package) => new Entrypoint(package, cache));
Indent +2.

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/version_solv...
File utils/pub/version_solver.dart (right):

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/version_solv...
utils/pub/version_solver.dart:239: final String package;
This now has a name, source, description, and version. Can you just use a
PackageRef (with the understanding that the version constraint will always be a
concrete version)?

[nweiz, 2012-09-18 19:55:30]

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart#new...
utils/pub/pub.dart:161: bool get usesEntrypoint => true;
On 2012/09/18 01:34:47, Bob Nystrom wrote:
> How about "requiresEntrypoint"?

Done.

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/pub.dart#new...
utils/pub/pub.dart:208: .transform((package) => new Entrypoint(package, cache));
On 2012/09/18 01:34:47, Bob Nystrom wrote:
> Indent +2.

Done.

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/version_solv...
File utils/pub/version_solver.dart (right):

https://chromiumcodereview.appspot.com/10938003/diff/1/utils/pub/version_solv...
utils/pub/version_solver.dart:239: final String package;
On 2012/09/18 01:34:47, Bob Nystrom wrote:
> This now has a name, source, description, and version. Can you just use a
> PackageRef (with the understanding that the version constraint will always be
a
> concrete version)?

I still feel like the semantics of the version identification here are slightly
different from the semantics of PackageId. PackageId represents a version of a
package, whereas this represents the change in that version. One concrete way
this manifests is the nullability of version; ChangeVersion.version is intended
to be nullable, since it can represent removing a dependency, whereas
PackgeId.version cannot be null because there can't be a package with no
version.

[Bob Nystrom, 2012-09-18 21:57:03]

LGTM!