- Do not limit the compiler message buffer, by allocating the message

- Do not limit the compiler message buffer, by allocating the message
  into a String object.
Committed: https://code.google.com/p/dart/source/detail?r=12202

[Mads Ager (google), 2012-09-11 14:42:16]

LGTM!

[hausner, 2012-09-11 16:11:14]

lgtm

https://chromiumcodereview.appspot.com/10933021/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10933021/diff/1/vm/object.cc#newcode9512
vm/object.cc:9512: va_copy(args_copy, args);
I am not familiar with va_copy. Is va_start no longer needed due to the va_copy?

[hausner, 2012-09-11 16:14:20]

This topic sounded familiar to me. Earlier this year, you mentioned in a code
review for Siva:

"You need to use va_copy, which unfortunately is not available in older
versions of MSVC."

[Ivan Posva, 2012-09-11 16:14:39]

https://chromiumcodereview.appspot.com/10933021/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10933021/diff/1/vm/object.cc#newcode9512
vm/object.cc:9512: va_copy(args_copy, args);
On 2012/09/11 16:11:14, hausner wrote:
> I am not familiar with va_copy. Is va_start no longer needed due to the
va_copy?

va_copy creates a copy of the passed in va_list args as the use of args is
destructive. Essentially it is in place of a va_start, which is used when
dealing with ... parameters.