- Do not limit the compiler message buffer, by allocating the message

vm/object.cc

Index: vm/object.cc
===================================================================
--- vm/object.cc	(revision 12163)
+++ vm/object.cc	(working copy)
@@ -9500,15 +9500,22 @@
 RawString* String::NewFormatted(const char* format, ...) {
   va_list args;
   va_start(args, format);
-  intptr_t len = OS::VSNPrint(NULL, 0, format, args);
+  RawString* result = NewFormattedV(format, args);
+  NoGCScope no_gc;
   va_end(args);
+  return result;
+}
 
+
+RawString* String::NewFormattedV(const char* format, va_list args) {
+  va_list args_copy;
+  va_copy(args_copy, args);

[hausner, 2012/09/11 16:11:14]

I am not familiar with va_copy. Is va_start no longer needed due to the va_copy?

[Ivan Posva, 2012/09/11 16:14:39]

va_copy creates a copy of the passed in va_list args as the use of args is
destructive. Essentially it is in place of a va_start, which is used when
dealing with ... parameters.

+  intptr_t len = OS::VSNPrint(NULL, 0, format, args_copy);
+  va_end(args_copy);
+
   Zone* zone = Isolate::Current()->current_zone();
   char* buffer = zone->Alloc<char>(len + 1);
-  va_list args2;
-  va_start(args2, format);
-  OS::VSNPrint(buffer, (len + 1), format, args2);
-  va_end(args2);
+  OS::VSNPrint(buffer, (len + 1), format, args);
 
   return String::New(buffer);
 }