Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl…

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inline cache misses in optimized code (a big no-no). Committed: https://code.google.com/p/dart/source/detail?r=12208

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -13 lines)			Patch
M	runtime/lib/array_patch.dart	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	2 chunks	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/optimized_lists.dart	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://chromiumcodereview.appspot.com/10933019/diff/6001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10933019/diff/6001/runtime/vm/flow_graph_builder.cc#newcode1671 runtime/vm/flow_graph_builder.cc:1671: if (function_class.library() == core_impl_lib.raw()) { This code is ...

8 years, 3 months ago (2012-09-11 12:30:39 UTC) #2

srdjan

8 years, 3 months ago (2012-09-11 15:23:16 UTC) #3

https://chromiumcodereview.appspot.com/10933019/diff/6001/runtime/vm/flow_gra...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10933019/diff/6001/runtime/vm/flow_gra...
runtime/vm/flow_graph_builder.cc:1671: if (function_class.library() ==
core_impl_lib.raw()) {
On 2012/09/11 12:30:40, Vyacheslav Egorov (Google) wrote:
> This code is very tied to the actual behavior of List-constructor.
> 
> Please make sure that we have good test coverage for this.
> 
> Additionally consider adding a comment in the List constructor that optimizer
> relies on this.

Done & Done

Expand Messages | Collapse Messages