Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 10933019: Improve moves of Smi and null objects. Add result cid to List constructor calls. Add tracing of inl… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/memory_region.h" 10 #include "vm/memory_region.h"
(...skipping 1509 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 for (intptr_t i = 0; i < stack_elements; i++) { 1520 for (intptr_t i = 0; i < stack_elements; i++) {
1521 popq(TMP); 1521 popq(TMP);
1522 } 1522 }
1523 return; 1523 return;
1524 } 1524 }
1525 addq(RSP, Immediate(stack_elements * kWordSize)); 1525 addq(RSP, Immediate(stack_elements * kWordSize));
1526 } 1526 }
1527 1527
1528 1528
1529 void Assembler::LoadObject(Register dst, const Object& object) { 1529 void Assembler::LoadObject(Register dst, const Object& object) {
1530 if (object.IsSmi()) { 1530 if (object.IsSmi() || object.IsNull()) {
1531 movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw()))); 1531 movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
1532 } else { 1532 } else {
1533 ASSERT(object.IsZoneHandle()); 1533 ASSERT(object.IsZoneHandle());
1534 AssemblerBuffer::EnsureCapacity ensured(&buffer_); 1534 AssemblerBuffer::EnsureCapacity ensured(&buffer_);
1535 EmitRegisterREX(dst, REX_W); 1535 EmitRegisterREX(dst, REX_W);
1536 EmitUint8(0xB8 | (dst & 7)); 1536 EmitUint8(0xB8 | (dst & 7));
1537 buffer_.EmitObject(object); 1537 buffer_.EmitObject(object);
1538 } 1538 }
1539 } 1539 }
1540 1540
1541 1541
1542 void Assembler::StoreObject(const Address& dst, const Object& object) { 1542 void Assembler::StoreObject(const Address& dst, const Object& object) {
1543 if (object.IsSmi()) { 1543 if (object.IsSmi() || object.IsNull()) {
1544 movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw()))); 1544 movq(dst, Immediate(reinterpret_cast<int64_t>(object.raw())));
1545 } else { 1545 } else {
1546 LoadObject(TMP, object); 1546 LoadObject(TMP, object);
1547 movq(dst, TMP); 1547 movq(dst, TMP);
1548 } 1548 }
1549 } 1549 }
1550 1550
1551 1551
1552 void Assembler::PushObject(const Object& object) { 1552 void Assembler::PushObject(const Object& object) {
1553 if (object.IsSmi()) { 1553 if (object.IsSmi() || object.IsNull()) {
1554 pushq(Immediate(reinterpret_cast<int64_t>(object.raw()))); 1554 pushq(Immediate(reinterpret_cast<int64_t>(object.raw())));
1555 } else { 1555 } else {
1556 LoadObject(TMP, object); 1556 LoadObject(TMP, object);
1557 pushq(TMP); 1557 pushq(TMP);
1558 } 1558 }
1559 } 1559 }
1560 1560
1561 1561
1562 void Assembler::CompareObject(Register reg, const Object& object) { 1562 void Assembler::CompareObject(Register reg, const Object& object) {
1563 if (object.IsSmi()) { 1563 if (object.IsSmi() || object.IsNull()) {
1564 cmpq(reg, Immediate(reinterpret_cast<int64_t>(object.raw()))); 1564 cmpq(reg, Immediate(reinterpret_cast<int64_t>(object.raw())));
1565 } else { 1565 } else {
1566 ASSERT(reg != TMP); 1566 ASSERT(reg != TMP);
1567 LoadObject(TMP, object); 1567 LoadObject(TMP, object);
1568 cmpq(reg, TMP); 1568 cmpq(reg, TMP);
1569 } 1569 }
1570 } 1570 }
1571 1571
1572 1572
1573 // Destroys the value register. 1573 // Destroys the value register.
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
1984 1984
1985 const char* Assembler::XmmRegisterName(XmmRegister reg) { 1985 const char* Assembler::XmmRegisterName(XmmRegister reg) {
1986 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 1986 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
1987 return xmm_reg_names[reg]; 1987 return xmm_reg_names[reg];
1988 } 1988 }
1989 1989
1990 1990
1991 } // namespace dart 1991 } // namespace dart
1992 1992
1993 #endif // defined TARGET_ARCH_X64 1993 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/code_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698