Issue 10928145: Patch print directly in corelib instead of going through coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10928145: Patch print directly in corelib instead of going through coreimpl. (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Patch print directly in corelib instead of going through coreimpl. R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12316

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -42 lines)			Patch
M	lib/compiler/implementation/lib/core_patch.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	lib/core/print.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	lib/coreimpl/coreimpl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/coreimpl/corelib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	lib/coreimpl/print.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/lib/lib_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/print_patch.dart	View	1 chunk	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, this is very nice! Do we have to change anything in dartium world?

8 years, 3 months ago (2012-09-12 14:52:34 UTC) #2

Mads Ager (google)

8 years, 3 months ago (2012-09-13 06:23:49 UTC) #3

On 2012/09/12 14:52:34, ajohnsen wrote:
> LGTM, this is very nice! Do we have to change anything in dartium world?

Yes, we do. Code review up here:
https://chromiumcodereview.appspot.com/10928146/

Expand Messages | Collapse Messages