runtime/bin/dartutils.cc - Issue 10928145: Patch print directly in corelib instead of going through coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dartutils.cc

Issue 10928145: Patch print directly in corelib instead of going through coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/dartutils.cc

diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc

index 0524f84383abf980eeef9da6b1fc2b773a321318..33e4a540177701966e9f6f47e63cc52d9e9a8fa8 100644

--- a/runtime/bin/dartutils.cc

+++ b/runtime/bin/dartutils.cc

@@ -398,10 +398,8 @@ Dart_Handle DartUtils::PrepareForScriptLoading(const char* package_root,

// Setup the corelib 'print' function.

Dart_Handle print =

Dart_Invoke(builtin_lib, Dart_NewString("_getPrintClosure"), 0, 0);

- Dart_Handle coreimpl = Dart_LookupLibrary(Dart_NewString("dart:coreimpl"));

- Dart_Handle print_impl =

- Dart_GetClass(coreimpl, Dart_NewString("PrintImplementation"));

- Dart_Handle result = Dart_SetField(print_impl,

+ Dart_Handle corelib = Dart_LookupLibrary(Dart_NewString("dart:core"));

+ Dart_Handle result = Dart_SetField(corelib,

Dart_NewString("_printClosure"), print);

// Setup the 'timer' factory.

« no previous file with comments | « lib/coreimpl/print.dart ('k') | runtime/lib/lib_impl_sources.gypi » ('j') | no next file with comments »