Issue 10920010: Check if the decomposed date is in the correct range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10920010: Check if the decomposed date is in the correct range. (Closed)

Created:
8 years, 3 months ago by floitsch

Modified:
8 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check if the decomposed date is in the correct range. On IE Date.UTC does not return NaN for decomposed dates that lie outside the valid range. Therefore add an additional check. Fixes issue 4836. Committed: https://code.google.com/p/dart/source/detail?r=11799

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	lib/compiler/implementation/lib/js_helper.dart	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/date_time_test.dart	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages