Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10920010: Check if the decomposed date is in the correct range. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index 685226a4c9f969cbe9ca0704336a9feab31afc4d..41c8b7b154352ac5e36eae41890de13ecb87975c 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -436,6 +436,7 @@ class Primitives {
static valueFromDecomposedDate(years, month, day, hours, minutes, seconds,
milliseconds, isUtc) {
+ final int MAX_MILLISECONDS_SINCE_EPOCH = 8640000000000000;
checkInt(years);
checkInt(month);
checkInt(day);
@@ -453,7 +454,11 @@ class Primitives {
value = JS('num', @'new Date(#, #, #, #, #, #, #).valueOf()',
years, jsMonth, day, hours, minutes, seconds, milliseconds);
}
- if (value.isNaN()) throw new IllegalArgumentException();
+ if (value.isNaN() ||
+ value < -MAX_MILLISECONDS_SINCE_EPOCH ||
+ value > MAX_MILLISECONDS_SINCE_EPOCH) {
+ throw new IllegalArgumentException();
+ }
if (years <= 0 || years < 100) return patchUpY2K(value, years, isUtc);
return value;
}
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698