Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10918073: Issue 4881. Resolve new == and []+ operators (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 3 months ago (2012-09-05 15:21:00 UTC) #1
Brian Wilkerson
LGTM. Does this finish the removal of support for the old operator syntax, or is ...
8 years, 3 months ago (2012-09-05 15:57:51 UTC) #2
scheglov
8 years, 3 months ago (2012-09-05 16:03:57 UTC) #3
Yes, AFAIK this finishes removal of old operator syntax.
I will need to update Clean Up wizard though...
Right now it supports only "equals" migration.

https://chromiumcodereview.appspot.com/10918073/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
(right):

https://chromiumcodereview.appspot.com/10918073/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java:63:
//  private static InterfaceType getType(String[] names, Scope scope,
DartCompilerListener listener) {
On 2012/09/05 15:57:51, Brian Wilkerson wrote:
> Did you intend to leave this method in the code in case we need it later, or
did
> you intend to remove it? (Either way is fine with me.)

I was going to keep this method, but after closer look I found that it is not
interesting, so we can remove it completely.

Powered by Google App Engine
This is Rietveld 408576698