Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java

Issue 10918073: Issue 4881. Resolve new == and []+ operators (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java b/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
index 14c97bc507e1fbc3ff213ecd5519df6b67fbc74e..b6402eeb4856ae94e91430c1c56ab7fe8d7e4832 100644
--- a/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
+++ b/compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java
@@ -60,22 +60,22 @@ public class CoreTypeProviderImplementation implements CoreTypeProvider {
return element.getType();
}
- private static InterfaceType getType(String[] names, Scope scope, DartCompilerListener listener) {
- ClassElement element = null;
- for (String name : names) {
- element = (ClassElement) scope.findElement(scope.getLibrary(), name);
- if (element != null)
- break;
- }
- if (element == null) {
- DartCompilationError error =
- new DartCompilationError(null, Location.NONE,
- ResolverErrorCode.CANNOT_RESOLVE_SDK_TYPE, names[0]);
- listener.onError(error);
- return Types.newDynamicType();
- }
- return element.getType();
- }
+// private static InterfaceType getType(String[] names, Scope scope, DartCompilerListener listener) {
Brian Wilkerson 2012/09/05 15:57:51 Did you intend to leave this method in the code in
scheglov 2012/09/05 16:03:57 I was going to keep this method, but after closer
+// ClassElement element = null;
+// for (String name : names) {
+// element = (ClassElement) scope.findElement(scope.getLibrary(), name);
+// if (element != null)
+// break;
+// }
+// if (element == null) {
+// DartCompilationError error =
+// new DartCompilationError(null, Location.NONE,
+// ResolverErrorCode.CANNOT_RESOLVE_SDK_TYPE, names[0]);
+// listener.onError(error);
+// return Types.newDynamicType();
+// }
+// return element.getType();
+// }
@Override
public InterfaceType getIntType() {
« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698