Changing websocket API to make it possible to send array buffers.

Changing websocket API to make it possible to send array buffers.


BUG=2766
Committed: https://code.google.com/p/dart/source/detail?r=11845

[vsm, 2012-09-04 19:55:18]

https://chromiumcodereview.appspot.com/10918059/diff/7/lib/dom/idl/dart/dart.idl
File lib/dom/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10918059/diff/7/lib/dom/idl/dart/dart....
lib/dom/idl/dart/dart.idl:312: [Custom] boolean send(in custom data)
raises(DOMException);
I'd prefer not making the type of data 'custom' as this might fail in very
surprising ways if you pass an arbitrary object.

The spec (http://dev.w3.org/html5/websockets/) lists 4 variants:
  void send(DOMString data);
  void send(Blob data);
  void send(ArrayBuffer data);
  void send(ArrayBufferView data);

Will our codegen do the right thing if we list these here explicitly?

[blois, 2012-09-04 21:07:07]

https://chromiumcodereview.appspot.com/10918059/diff/7/lib/dom/idl/dart/dart.idl
File lib/dom/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10918059/diff/7/lib/dom/idl/dart/dart....
lib/dom/idl/dart/dart.idl:312: [Custom] boolean send(in custom data)
raises(DOMException);
Looks like it does, I've made this change.

On 2012/09/04 19:55:18, vsm wrote:
> I'd prefer not making the type of data 'custom' as this might fail in very
> surprising ways if you pass an arbitrary object.
> 
> The spec (http://dev.w3.org/html5/websockets/) lists 4 variants:
>   void send(DOMString data);
>   void send(Blob data);
>   void send(ArrayBuffer data);
>   void send(ArrayBufferView data);
> 
> Will our codegen do the right thing if we list these here explicitly?

[vsm, 2012-09-04 21:19:03]

lgtm