Changing websocket API to make it possible to send array buffers.

lib/dom/idl/dart/dart.idl

 
 // This file introduces / supplements and forces Dart declarations.
 
 module default {
   FileList implements sequence<File>;
   HTMLCollection implements sequence<Node>;
   MediaList implements sequence<DOMString>;
   NamedNodeMap implements sequence<Node>;
   NodeList implements sequence<Node>;
   StyleSheetList implements sequence<StyleSheet>;
@@ skipping 284 matching lines @@
 
 module storage {
   [Supplemental]
   interface SQLResultSetRowList {
     // Change the return type to Dictionary so that rows are exposed in the Dart
     // API as a Maps, with the appropriate conversion in JavaScript.
     [Suppressed] DOMObject item(in unsigned long index);
     [Custom] Dictionary item(in unsigned long index);
   };
 }
+
+module websockets {
+  [Supplemental]
+  interface WebSocket {
+    // Change the return type to custom so that it can be either ArrayBuffer
+    // or string.
+    [Suppressed] boolean send(in DOMString data) raises(DOMException);
+    [Custom] boolean send(in custom data) raises(DOMException);

[vsm, 2012/09/04 19:55:18]

I'd prefer not making the type of data 'custom' as this might fail in very
surprising ways if you pass an arbitrary object.

The spec (http://dev.w3.org/html5/websockets/) lists 4 variants:
  void send(DOMString data);
  void send(Blob data);
  void send(ArrayBuffer data);
  void send(ArrayBufferView data);

Will our codegen do the right thing if we list these here explicitly?

[blois, 2012/09/04 21:07:07]

Looks like it does, I've made this change.

On 2012/09/04 19:55:18, vsm wrote:

+  };
+}
+