Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 10917208: Change interfaces to abstract classes in dart2js compiler. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Change interfaces to abstract classes in dart2js compiler. There are still a few interfaces left. They use the 'default implementation' feature that can't be replaced until we implement const constructor forwarding. Also removed mockimpl.dart. We don't pretend to support ReceiverPortFactory (whatever it is) if it is not in the core library. Committed: https://code.google.com/p/dart/source/detail?r=12252

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -58 lines) Patch
M lib/compiler/implementation/constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/diagnostic_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/js/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/isolate_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/mock.dart View 1 chunk +1 line, -14 lines 0 comments Download
D lib/compiler/implementation/lib/mockimpl.dart View 1 chunk +0 lines, -13 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 2 chunks +9 lines, -9 lines 2 comments Download
M lib/compiler/implementation/ssa/nodes.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M lib/compiler/implementation/ssa/optimize.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/tree/nodes.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-12 09:28:21 UTC) #1
ngeoffray
STV! https://chromiumcodereview.appspot.com/10917208/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/10917208/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode713 lib/compiler/implementation/ssa/builder.dart:713: factory JumpHandler(SsaBuilder builder, TargetElement target) { You know ...
8 years, 3 months ago (2012-09-12 09:30:56 UTC) #2
Lasse Reichstein Nielsen
8 years, 3 months ago (2012-09-12 10:17:46 UTC) #3
https://chromiumcodereview.appspot.com/10917208/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10917208/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:713: factory JumpHandler(SsaBuilder
builder, TargetElement target) {
I think it'll still be valid. We still need normal factory methods, and not
forwarding constructors (that may or may not be generative for the class they
forward to).

Powered by Google App Engine
This is Rietveld 408576698