Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10917208: Change interfaces to abstract classes in dart2js compiler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/nodes.dart
diff --git a/lib/compiler/implementation/ssa/nodes.dart b/lib/compiler/implementation/ssa/nodes.dart
index 8efd5d457c1f087a60bb4e92930860a73fb35f3f..f71632d0c8c147c6402d0052c5cb914cff678647 100644
--- a/lib/compiler/implementation/ssa/nodes.dart
+++ b/lib/compiler/implementation/ssa/nodes.dart
@@ -2,7 +2,7 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-interface HVisitor<R> {
+abstract class HVisitor<R> {
R visitAdd(HAdd node);
R visitBailoutTarget(HBailoutTarget node);
R visitBitAnd(HBitAnd node);
@@ -2641,7 +2641,7 @@ class HBlockFlow {
/**
* Information about a syntactic-like structure.
*/
-interface HBlockInformation {
+abstract class HBlockInformation {
HBasicBlock get start;
HBasicBlock get end;
bool accept(HBlockInformationVisitor visitor);
@@ -2651,7 +2651,7 @@ interface HBlockInformation {
/**
* Information about a statement-like structure.
*/
-interface HStatementInformation extends HBlockInformation {
+abstract class HStatementInformation extends HBlockInformation {
bool accept(HStatementInformationVisitor visitor);
}
@@ -2659,13 +2659,13 @@ interface HStatementInformation extends HBlockInformation {
/**
* Information about an expression-like structure.
*/
-interface HExpressionInformation extends HBlockInformation {
+abstract class HExpressionInformation extends HBlockInformation {
bool accept(HExpressionInformationVisitor visitor);
HInstruction get conditionExpression;
}
-interface HStatementInformationVisitor {
+abstract class HStatementInformationVisitor {
bool visitLabeledBlockInfo(HLabeledBlockInformation info);
bool visitLoopInfo(HLoopBlockInformation info);
bool visitIfInfo(HIfBlockInformation info);
@@ -2678,14 +2678,14 @@ interface HStatementInformationVisitor {
}
-interface HExpressionInformationVisitor {
+abstract class HExpressionInformationVisitor {
bool visitAndOrInfo(HAndOrBlockInformation info);
bool visitSubExpressionInfo(HSubExpressionBlockInformation info);
}
-interface HBlockInformationVisitor extends HStatementInformationVisitor,
- HExpressionInformationVisitor {
+abstract class HBlockInformationVisitor
+ implements HStatementInformationVisitor, HExpressionInformationVisitor {
}

Powered by Google App Engine
This is Rietveld 408576698