Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 10916268: New 'Clean Up' to convert old optional parameters to the new optional named where possible. (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New 'Clean Up' to convert old optional parameters to the new optional named where possible. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=12282

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+440 lines, -34 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartFunction.java View 2 chunks +15 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 14 chunks +45 lines, -20 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeTestCase.java View 1 chunk +3 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java View 1 chunk +18 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/refactoring/util/ExecutionUtils.java View 1 chunk +11 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/CleanUpRefactoringWizard.java View 4 chunks +9 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_optionalNamed_CleanUp.java View 1 chunk +137 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/MigrateCleanUpTest.java View 2 chunks +201 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-12 19:11:22 UTC) #1
Brian Wilkerson
8 years, 3 months ago (2012-09-12 20:35:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698