Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java

Issue 10916268: New 'Clean Up' to convert old optional parameters to the new optional named where possible. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java
index d827bd1f780e9a50feaa45684f9aa7729bab6ee6..739fc9a760c329fc708b8ef642e2d622d599071c 100644
--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java
+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/FunctionCompleter.java
@@ -26,18 +26,29 @@ public class FunctionCompleter extends DartFunction implements CompletionNode {
static final long serialVersionUID = 1L;
public static FunctionCompleter from(DartFunction p) {
- return CompletionUtil.init(new FunctionCompleter(
- p.getParameters(),
- p.getParametersCloseParen(),
- p.getBody(),
- p.getReturnTypeNode()), p);
+ return CompletionUtil.init(
+ new FunctionCompleter(
+ p.getParameters(),
+ p.getParametersOptionalOpen(),
+ p.getParametersOptionalClose(),
+ p.getParametersCloseParen(),
+ p.getBody(),
+ p.getReturnTypeNode()),
+ p);
}
private Stack<Mark> stack;
- public FunctionCompleter(List<DartParameter> params, int parametersCloseParen, DartBlock body,
+ public FunctionCompleter(List<DartParameter> params, int parametersOptionalOpen,
+ int parametersOptionalClose, int parametersCloseParen, DartBlock body,
DartTypeNode returnTypeNode) {
- super(params, parametersCloseParen, body, returnTypeNode);
+ super(
+ params,
+ parametersOptionalOpen,
+ parametersOptionalClose,
+ parametersCloseParen,
+ body,
+ returnTypeNode);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698