Issue 10916206: Fix for Directory.exists on Windows using GetFileAttributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10916206: Fix for Directory.exists on Windows using GetFileAttributes (Closed)

Created:
8 years, 3 months ago by Mads Ager (google)

Modified:
8 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for Directory.exists on Windows using GetFileAttributes based on patch from Alexander Aprelev. Discriminate different reasons for not being able to get the file attributes. Currently this makes no difference since both DOES_NOT_EXIST and UNKNOWN turn into a false return value from Directory.existsSync(). R=sgjesse@google.com BUG=3914 Committed: https://code.google.com/p/dart/source/detail?r=12106

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -25 lines)			Patch
M	runtime/bin/directory.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/bin/directory_win.cc	View	2 chunks	+13 lines, -19 lines	0 comments	Download
M	tests/standalone/io/directory_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages