Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: runtime/bin/directory.cc

Issue 10916206: Fix for Directory.exists on Windows using GetFileAttributes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/directory_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory.cc
diff --git a/runtime/bin/directory.cc b/runtime/bin/directory.cc
index 8455c39fb5e345fa1b2da7fd2b25cb63ccbbd7a9..9f8252741db1a8781833b245719ed7d3a0943ab4 100644
--- a/runtime/bin/directory.cc
+++ b/runtime/bin/directory.cc
@@ -298,24 +298,18 @@ CObjectArray* DirectoryListing::NewResponse(Response type, char* arg) {
bool DirectoryListing::HandleDirectory(char* dir_name) {
- // TODO(sgjesse): Pass flags to indicate whether directory
- // responses are needed.
CObjectArray* response = NewResponse(kListDirectory, dir_name);
return Dart_PostCObject(response_port_, response->AsApiCObject());
}
bool DirectoryListing::HandleFile(char* file_name) {
- // TODO(sgjesse): Pass flags to indicate whether file
- // responses are needed.
CObjectArray* response = NewResponse(kListFile, file_name);
return Dart_PostCObject(response_port_, response->AsApiCObject());
}
bool DirectoryListing::HandleError(const char* dir_name) {
- // TODO(sgjesse): Pass flags to indicate whether error
- // responses are needed.
CObject* err = CObject::NewOSError();
CObjectArray* response = new CObjectArray(CObject::NewArray(3));
response->SetAt(0, new CObjectInt32(CObject::NewInt32(kListError)));
« no previous file with comments | « no previous file | runtime/bin/directory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698