Issue 10915120: In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers on…

Issue 10915120: In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers on… (Closed)

Created:
8 years, 3 months ago by srdjan

Modified:
8 years, 3 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In preparation for lazy deoptimization add "is_alive_" field to RawCode: visit embedded pointers only if it is set to true. It will be set to false when patching the code to call lazy deopt-trampoline stub, thus potentially destroying embedded pointers. Committed: https://code.google.com/p/dart/source/detail?r=11969

Patch Set 1 #

Total comments: 4

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -7 lines)			Patch
M	runtime/vm/object.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+4 lines, -1 line	2 comments	Download
M	runtime/vm/raw_object.cc	View	1 chunk	+9 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object.cc File runtime/vm/raw_object.cc (right): https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object.cc#newcode449 runtime/vm/raw_object.cc:449: } I am assuming the change to mark ...

8 years, 3 months ago (2012-09-06 16:57:55 UTC) #2

srdjan

8 years, 3 months ago (2012-09-06 17:06:03 UTC) #3

https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object.cc
File runtime/vm/raw_object.cc (right):

https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object....
runtime/vm/raw_object.cc:449: }
On 2012/09/06 16:57:55, asiva wrote:
> I am assuming the change to mark an object as not alive is still pending.

Correct.

https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://chromiumcodereview.appspot.com/10915120/diff/1/runtime/vm/raw_object....
runtime/vm/raw_object.h:769: intptr_t is_alive_;
On 2012/09/06 16:57:55, asiva wrote:
> Not for this CL but at some point we should consider making these fields bit
> fields (similar to what we have done with function, field etc.

Agree.

Expand Messages | Collapse Messages