Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 10913112: Clean ups for trailing whitespace and block style (Closed)

Created:
8 years, 3 months ago by scheglov
Modified:
8 years, 3 months ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean ups for trailing whitespace and block style Also M1 migration for 'operator negate()'. R=messick@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11957

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -95 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartForInStatement.java View 1 chunk +7 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartForStatement.java View 1 chunk +7 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartIfStatement.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/ast/DartWhileStatement.java View 2 chunks +7 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 5 chunks +8 lines, -5 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/AST.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/META-INF/MANIFEST.MF View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/SourceRangeFactory.java View 1 chunk +8 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/CleanUpRefactoringWizard.java View 10 chunks +79 lines, -7 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_equals_CleanUp.java View 1 chunk +0 lines, -41 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_trailingSpace_CleanUp.java View 1 chunk +43 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_useBlocks_CleanUp.java View 1 chunk +174 lines, -0 lines 2 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/AbstractCleanUpTest.java View 1 chunk +60 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/MigrateCleanUpTest.java View 4 chunks +28 lines, -36 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java View 1 chunk +264 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 3 months ago (2012-09-06 14:03:57 UTC) #1
messick
8 years, 3 months ago (2012-09-06 14:50:45 UTC) #2
lgtm

https://chromiumcodereview.appspot.com/10913112/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_useBlocks_CleanUp.java
(right):

https://chromiumcodereview.appspot.com/10913112/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_useBlocks_CleanUp.java:36:
public class Style_useBlocks_CleanUp extends AbstractMigrateCleanUp {
I'm going to leave it to you, but I would have created constants to hold values
of "somestring".length(), especially since some of them are repeated.

https://chromiumcodereview.appspot.com/10913112/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/style/Style_useBlocks_CleanUp.java:72:
SourceRangeFactory.forStartLength(node.getCloseParenOffset() + 1, 0),
I believe the style guide encourages single-line tests:
  if (!guardClause()) return;
You should add a newline in these cases. (Yes, a problem better solved by a
formatter, but we're not there yet.)

Powered by Google App Engine
This is Rietveld 408576698