Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java

Issue 10913112: Clean ups for trailing whitespace and block style (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java
new file mode 100644
index 0000000000000000000000000000000000000000..1d512bbd9dbfd42910d1b0bd03976ab0e2c7a341
--- /dev/null
+++ b/editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/cleanup/StyleCleanUpTest.java
@@ -0,0 +1,264 @@
+/*
+ * Copyright (c) 2012, the Dart project authors.
+ *
+ * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.dart.tools.ui.cleanup;
+
+import com.google.dart.tools.ui.internal.cleanup.style.Style_trailingSpace_CleanUp;
+import com.google.dart.tools.ui.internal.cleanup.style.Style_useBlocks_CleanUp;
+
+/**
+ * Test for "Code Style" clean ups.
+ */
+public final class StyleCleanUpTest extends AbstractCleanUpTest {
+
+ public void test_trailingSpace() throws Exception {
+ ICleanUp cleanUp = new Style_trailingSpace_CleanUp();
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "",
+ " ",
+ " //",
+ " // ",
+ "class A { ",
+ "}",
+ "");
+ String expected = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "",
+ "",
+ " //",
+ " //",
+ "class A {",
+ "}",
+ "");
+ assertCleanUp(cleanUp, initial, expected);
+ }
+
+ public void test_useBlocks_always() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.ALWAYS);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " if (true)",
+ " process();",
+ " if (true)",
+ " process();",
+ " else",
+ " process();",
+ " if (false) {",
+ " process();",
+ " } else",
+ " process();",
+ " while (true)",
+ " process();",
+ " for (var item in [])",
+ " process();",
+ " for (var i = 0; i < 10; i++)",
+ " process();",
+ "}",
+ "process() {}",
+ "");
+ String expected = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " if (true) {",
+ " process();",
+ " }",
+ " if (true) {",
+ " process();",
+ " } else {",
+ " process();",
+ " }",
+ " if (false) {",
+ " process();",
+ " } else {",
+ " process();",
+ " }",
+ " while (true) {",
+ " process();",
+ " }",
+ " for (var item in []) {",
+ " process();",
+ " }",
+ " for (var i = 0; i < 10; i++) {",
+ " process();",
+ " }",
+ "}",
+ "process() {}",
+ "");
+ assertCleanUp(cleanUp, initial, expected);
+ }
+
+ public void test_useBlocks_always_nop() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.ALWAYS);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " if (true) {",
+ " process();",
+ " }",
+ " while (true) {",
+ " process();",
+ " }",
+ " for (var item in []) {",
+ " process();",
+ " }",
+ " for (var i = 0; i < 10; i++) {",
+ " process();",
+ " }",
+ "}",
+ "process() {}",
+ "");
+ assertNoFix(cleanUp, initial);
+ }
+
+ public void test_useBlocks_whenNecessary_ifThenElse() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.WHEN_NECESSARY);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " // 0",
+ " if (true) {",
+ " process();",
+ " }",
+ " // 1",
+ " if (true) {",
+ " process();",
+ " } else {",
+ " process();",
+ " }",
+ " // 2",
+ " if (true) {",
+ " process();",
+ " } else",
+ " process();",
+ " // 3",
+ " if (true)",
+ " process();",
+ " else {",
+ " process();",
+ " }",
+ "}",
+ "process() {}",
+ "");
+ String expected = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " // 0",
+ " if (true)",
+ " process();",
+ " // 1",
+ " if (true)",
+ " process();",
+ " else",
+ " process();",
+ " // 2",
+ " if (true)",
+ " process();",
+ " else",
+ " process();",
+ " // 3",
+ " if (true)",
+ " process();",
+ " else",
+ " process();",
+ "}",
+ "process() {}",
+ "");
+ assertCleanUp(cleanUp, initial, expected);
+ }
+
+ public void test_useBlocks_whenNecessary_loops() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.WHEN_NECESSARY);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " while (true) {",
+ " process();",
+ " }",
+ " for (var item in []) {",
+ " process();",
+ " }",
+ " for (var i = 0; i < 10; i++) {",
+ " process();",
+ " }",
+ "}",
+ "process() {}",
+ "");
+ String expected = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " while (true)",
+ " process();",
+ " for (var item in [])",
+ " process();",
+ " for (var i = 0; i < 10; i++)",
+ " process();",
+ "}",
+ "process() {}",
+ "");
+ assertCleanUp(cleanUp, initial, expected);
+ }
+
+ public void test_useBlocks_whenNecessary_nop_ifThenElse() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.WHEN_NECESSARY);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " if (true)",
+ " process();",
+ " if (true) {",
+ " process();",
+ " process();",
+ " }",
+ " if (true) {",
+ " process();",
+ " process();",
+ " } else",
+ " process();",
+ " if (true)",
+ " process();",
+ " else {",
+ " process();",
+ " process();",
+ " }",
+ "}",
+ "process() {}",
+ "");
+ assertNoFix(cleanUp, initial);
+ }
+
+ public void test_useBlocks_whenNecessary_nop_loops() throws Exception {
+ Style_useBlocks_CleanUp cleanUp = new Style_useBlocks_CleanUp();
+ cleanUp.setFlag(Style_useBlocks_CleanUp.WHEN_NECESSARY);
+ String initial = makeSource(
+ "// filler filler filler filler filler filler filler filler filler filler",
+ "main() {",
+ " while (true)",
+ " process();",
+ " for (var item in [])",
+ " process();",
+ " for (var i = 0; i < 10; i++)",
+ " process();",
+ "}",
+ "process() {}",
+ "");
+ assertNoFix(cleanUp, initial);
+ }
+
+}

Powered by Google App Engine
This is Rietveld 408576698